Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch order params & resting orders to use token not atoms #38

Merged
merged 23 commits into from
Aug 31, 2024

Conversation

DonDuala
Copy link
Contributor

No description provided.

@DonDuala DonDuala requested a review from brittcyr August 28, 2024 18:00
client/ts/src/client.ts Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
client/ts/src/client.ts 81.81% 0 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@DonDuala DonDuala changed the title Switch order params to use token price Switch order params & resting orders to use token not atoms Aug 30, 2024
@DonDuala DonDuala requested a review from brittcyr August 30, 2024 21:07
client/ts/src/client.ts Show resolved Hide resolved
client/ts/src/client.ts Show resolved Hide resolved
client/ts/src/market.ts Outdated Show resolved Hide resolved
client/ts/src/market.ts Show resolved Hide resolved
@brittcyr
Copy link
Contributor

Can ignore codecov for now. I will go back and increase it during a larger cleanup

@DonDuala DonDuala merged commit 3aad209 into main Aug 31, 2024
5 checks passed
@DonDuala DonDuala deleted the token-orders branch August 31, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants